Skip to content

[DOC] Doc for accept_charset and accept_charset=#97

Merged
hsbt merged 1 commit into
ruby:masterfrom
BurdetteLamar:cgi_accept_charset_doc
Jun 23, 2026
Merged

[DOC] Doc for accept_charset and accept_charset=#97
hsbt merged 1 commit into
ruby:masterfrom
BurdetteLamar:cgi_accept_charset_doc

Conversation

@BurdetteLamar

Copy link
Copy Markdown
Member

No description provided.

@BurdetteLamar BurdetteLamar requested a review from nobu December 1, 2025 17:15
@BurdetteLamar BurdetteLamar added the documentation Improvements or additions to documentation label Dec 1, 2025
Comment thread lib/cgi/core.rb
Comment on lines +821 to +825
# The given encoding is not checked in this method,
# but if it is invalid, a call to CGI.new will fail:
#
# CGI.accept_charset = 'foo'
# CGI.new # Raises ArgumentError: unknown encoding name - foo

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is an implementation detail and probably not worth mentioning (it actually looks like a bug we should fix).

@hsbt hsbt merged commit 5f26d1a into ruby:master Jun 23, 2026
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants